ionic-team / stencil

A toolchain for building scalable, enterprise-ready component systems on top of TypeScript and Web Component standards. Stencil components can be distributed natively to React, Angular, Vue, and traditional web developers from a single, framework-agnostic codebase.
https://stenciljs.com
Other
12.5k stars 783 forks source link

bug: Failing to load a nested component hides all parents #5703

Open mhoritani opened 4 months ago

mhoritani commented 4 months ago

Prerequisites

Stencil Version

4.17.1

Current Behavior

If a component is nested inside another component AND the nested component cannot be rendered fully because its entry point can't be loaded then the parent component will not display at all because it never receives the .hydrated css class.

While the issue of a bundle not loading is certainly not a StencilJS issue, the behavior of the parent component not rendering - especially thinking of an icon deeply nested inside many bigger components has quite a big impact which is problematic.

Expected Behavior

The parent component should still receive the hydrated class and be displayed even if a nested component bundle cannot be loaded.

System Info

No response

Steps to Reproduce

Code Reproduction URL

https://stackblitz.com/edit/stencil-repro-mh-04-24?file=src%2Findex.html

Additional Information

No response

rwaskiewicz commented 4 months ago

Hey @mhoritani đŸ‘‹

Thanks for the issue with the repro case! It was super easy/helpful to understand what's going on here. I've labeled this as a bug to get ingested it into our backlog.