Closed yigityuce closed 1 month ago
--strictNullChecks
error reportTypechecking with --strictNullChecks
resulted in 1121 errors on this branch.
Unfortunately, it looks like that's an increase of 1 over main
๐.
There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9170173407/artifacts/1521832750
If your browser saves files to ~/Downloads
you can install it like so:
unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.2-dev.1716274317.524f100.tgz.zip && npm install ~/Downloads/stencil-core-4.18.2-dev.1716274317.524f100.tgz
@yigityuce thanks for the PR. I wonder if we can have a WDIO component test for this ๐ค
@yigityuce thanks for the PR. I wonder if we can have a WDIO component test for this ๐ค
@christian-bromann added test cases ๐งช
@christian-bromann & @alicewriteswrongs test cases are updated to remove duplicated await statement
thanks @christian-bromann we are waiting someone else to approve too right?
What is the current behavior?
GitHub Issue Number: #5774
What is the new behavior?
Documentation
Does this introduce a breaking change?
Testing
Other information