Add ESM export of hydrate app.

[thure]

Currently trying to integrate Stencil with Astro, see the thread in Discord.

If this approach works, I’ll create an issue and prepare this PR for review.

[github-actions[bot]]

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9422376103/artifacts/1580444569

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.3-dev.1717789891.254798a.tgz.zip && npm install ~/Downloads/stencil-core-4.18.3-dev.1717789891.254798a.tgz

[github-actions[bot]]

@stencil/core@4.18.3 ts tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1081 errors on this branch.

Unfortunately, it looks like that's an increase of 1 over main 😞.

Violations Not on `main` (may be more than the count above)

| Path | Location | Error | Message | | --- | --- | --- | --- | | src/compiler/output-targets/dist-hydrate-script/write-hydrate-outputs.ts | (35, 40) | TS2345 | | src/compiler/output-targets/dist-hydrate-script/write-hydrate-outputs.ts | (36, 40) | TS2345 | | src/compiler/output-targets/dist-hydrate-script/write-hydrate-outputs.ts | (37, 44) | TS2345 | | src/compiler/output-targets/dist-hydrate-script/write-hydrate-outputs.ts | (39, 28) | TS2345 | | src/compiler/output-targets/dist-hydrate-script/write-hydrate-outputs.ts | (49, 47) | TS2345 | | src/compiler/output-targets/dist-hydrate-script/write-hydrate-outputs.ts | (60, 31) | TS2345 |

reports and statistics

Our most error-prone files

| Path | Error Count | | --- | --- | | src/dev-server/index.ts | 37 | | src/dev-server/server-process.ts | 32 | | src/compiler/prerender/prerender-main.ts | 22 | | src/runtime/vdom/vdom-render.ts | 21 | | src/runtime/client-hydrate.ts | 20 | | src/screenshot/connector-base.ts | 19 | | src/testing/puppeteer/puppeteer-element.ts | 19 | | src/dev-server/request-handler.ts | 15 | | src/compiler/prerender/prerender-optimize.ts | 14 | | src/compiler/sys/stencil-sys.ts | 14 | | src/runtime/connected-callback.ts | 14 | | src/sys/node/node-sys.ts | 14 | | src/compiler/prerender/prerender-queue.ts | 13 | | src/compiler/sys/in-memory-fs.ts | 13 | | src/runtime/set-value.ts | 13 | | src/compiler/output-targets/output-www.ts | 12 | | src/compiler/transformers/test/parse-vdom.spec.ts | 12 | | src/compiler/transformers/transform-utils.ts | 12 | | src/mock-doc/test/attribute.spec.ts | 12 | | src/compiler/build/compiler-ctx.ts | 11 |

Our most common errors

| [Typescript Error Code](https://github.com/microsoft/TypeScript/blob/main/src/compiler/diagnosticMessages.json) | Count | | --- | --- | | TS2322 | 351 | | TS2345 | 331 | | TS18048 | 193 | | TS18047 | 76 | | TS2722 | 27 | | TS2532 | 24 | | TS2531 | 19 | | TS2454 | 14 | | TS2790 | 11 | | TS2352 | 9 | | TS2769 | 8 | | TS2416 | 7 | | TS2538 | 4 | | TS2493 | 3 | | TS18046 | 2 | | TS2684 | 1 | | TS2430 | 1 |

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

| File | Line | Identifier | | --- | --- | --- | | src/runtime/bootstrap-lazy.ts | 21 | setNonce | | src/screenshot/screenshot-fs.ts | 18 | readScreenshotData | | src/testing/testing-utils.ts | 198 | withSilentWarn | | src/utils/index.ts | 145 | CUSTOM | | src/utils/index.ts | 245 | NODE_TYPES | | src/utils/index.ts | 269 | normalize | | src/utils/index.ts | 7 | escapeRegExpSpecialCharacters | | src/compiler/app-core/app-data.ts | 25 | BUILD | | src/compiler/app-core/app-data.ts | 116 | Env | | src/compiler/app-core/app-data.ts | 118 | NAMESPACE | | src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild | | src/compiler/types/validate-primary-package-output-target.ts | 61 | satisfies | | src/compiler/types/validate-primary-package-output-target.ts | 61 | Record | | src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions | | src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |

[christian-bromann]

@thure thanks for raising the PR, I've started work on this already in #5792, do you think this implementation differs from this PR?

[thure]

@christian-bromann That’s brilliant, I’m sure this implementation would be equivalent at best, so please feel free to close this PR.

[christian-bromann]

Thanks, I hope we will be able to release this in the upcoming week(s). Keep an eye on that PR 😉