Closed christian-bromann closed 3 months ago
Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9523071323/artifacts/1603772922
If your browser saves files to ~/Downloads
you can install it like so:
unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.3-dev.1718403954.cddbd5d.tgz.zip && npm install ~/Downloads/stencil-core-4.18.3-dev.1718403954.cddbd5d.tgz
@stencil/core@4.18.3 ts tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts
--strictNullChecks
error reportTypechecking with --strictNullChecks
resulted in 1080 errors on this branch.
That's the same number of errors on main, so at least we're not creating new ones!
There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
What is the current behavior?
Currently Stencil tears down all pages in an
afterEach
hook which causes issues when you re-use a page object across multiple it blocks, e.g.:fixes #3720
What is the new behavior?
Let's not remove all pages after each
it
block and instead do it after all it blocks or when the user is creating anewE2EPage
object.Documentation
n/a
Does this introduce a breaking change?
Testing
Added an e2e test to verify this expected behavior works.
Other information
n/a