Closed christian-bromann closed 1 week ago
Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9569011399/artifacts/1613766170
If your browser saves files to ~/Downloads
you can install it like so:
unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.3-dev.1718729336.2ff4908.tgz.zip && npm install ~/Downloads/stencil-core-4.18.3-dev.1718729336.2ff4908.tgz
@stencil/core@4.18.3 ts tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts
--strictNullChecks
error reportTypechecking with --strictNullChecks
resulted in 1083 errors on this branch.
Unfortunately, it looks like that's an increase of 3 over main
😞.
There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
@christian-bromann Quite a few failing tests and still seeing errors when running this in the reproduction
@tanner-reits I forgot to push 🙈 should be working now
What is the current behavior?
Fixes ionic-team/ionic-framework#29593
What is the new behavior?
The type fix I initially did suggested a different type ob the style object so this fix makes this more clear that
Cstr.style
can be either astring
or aRecord<string, string>
.Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a