search

ionic-team / stencil

A toolchain for building scalable, enterprise-ready component systems on top of TypeScript and Web Component standards. Stencil components can be distributed natively to React, Angular, Vue, and traditional web developers from a single, framework-agnostic codebase.
https://stenciljs.com
Other
12.51k stars 782 forks source link

fix(declarations): fix nightly build #5850

Closed christian-bromann closed 3 months ago

christian-bromann commented 3 months ago

What is the current behavior?

Stencils Nightly build is failing due to a type change made in #5792. The original intention was to reflect reality better because getHostRef may return undefined. However it seems easier to just revert this change for now to ensure we don't break Ionic when releasing the change.

What is the new behavior?

Reverted particular change.

Documentation

n/a

Does this introduce a breaking change?

Testing

n/a

Other information

Stencil nightly build: https://github.com/ionic-team/ionic-framework/actions/runs/9640370566/job/26608094616

github-actions[bot] commented 3 months ago

@stencil/core@4.18.3 ts tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1076 errors on this branch.

Unfortunately, it looks like that's an increase of 2 over main 😞.

Violations Not on `main` (may be more than the count above) | Path | Location | Error | Message | | --- | --- | --- | --- | | src/hydrate/platform/proxy-host-element.ts | (14, 5) | TS2322 | | src/runtime/bootstrap-lazy.ts | (153, 35) | TS2345 | | src/runtime/bootstrap-lazy.ts | (164, 45) | TS2345 | | src/runtime/bootstrap-lazy.ts | (169, 46) | TS2345 |

reports and statistics

Our most error-prone files | Path | Error Count | | --- | --- | | src/dev-server/index.ts | 37 | | src/dev-server/server-process.ts | 32 | | src/compiler/prerender/prerender-main.ts | 22 | | src/runtime/vdom/vdom-render.ts | 22 | | src/runtime/client-hydrate.ts | 20 | | src/runtime/vdom/test/patch.spec.ts | 19 | | src/runtime/vdom/test/util.spec.ts | 19 | | src/screenshot/connector-base.ts | 19 | | src/testing/puppeteer/puppeteer-element.ts | 19 | | src/dev-server/request-handler.ts | 15 | | src/runtime/connected-callback.ts | 15 | | src/compiler/prerender/prerender-optimize.ts | 14 | | src/compiler/sys/stencil-sys.ts | 14 | | src/sys/node/node-sys.ts | 14 | | src/compiler/prerender/prerender-queue.ts | 13 | | src/compiler/sys/in-memory-fs.ts | 13 | | src/runtime/set-value.ts | 13 | | src/compiler/output-targets/output-www.ts | 12 | | src/compiler/transformers/test/parse-vdom.spec.ts | 12 | | src/compiler/transformers/transform-utils.ts | 12 |
Our most common errors | [Typescript Error Code](https://github.com/microsoft/TypeScript/blob/main/src/compiler/diagnosticMessages.json) | Count | | --- | --- | | TS2322 | 338 | | TS2345 | 329 | | TS18048 | 185 | | TS18047 | 99 | | TS2722 | 27 | | TS2532 | 23 | | TS2531 | 19 | | TS2790 | 11 | | TS2454 | 10 | | TS2352 | 9 | | TS2769 | 8 | | TS2416 | 7 | | TS2538 | 4 | | TS2493 | 3 | | TS18046 | 2 | | TS2684 | 1 | | TS2430 | 1 |

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports | File | Line | Identifier | | --- | --- | --- | | src/runtime/bootstrap-lazy.ts | 22 | setNonce | | src/screenshot/screenshot-fs.ts | 18 | readScreenshotData | | src/testing/testing-utils.ts | 198 | withSilentWarn | | src/utils/index.ts | 145 | CUSTOM | | src/utils/index.ts | 245 | NODE_TYPES | | src/utils/index.ts | 269 | normalize | | src/utils/index.ts | 7 | escapeRegExpSpecialCharacters | | src/compiler/app-core/app-data.ts | 25 | BUILD | | src/compiler/app-core/app-data.ts | 116 | Env | | src/compiler/app-core/app-data.ts | 118 | NAMESPACE | | src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild | | src/compiler/types/validate-primary-package-output-target.ts | 82 | satisfies | | src/compiler/types/validate-primary-package-output-target.ts | 82 | Record | | src/testing/puppeteer/puppeteer-declarations.ts | 496 | WaitForEventOptions | | src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
github-actions[bot] commented 3 months ago

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9648111949/artifacts/1632257467

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.3-dev.1719242893.03e4c89.tgz.zip && npm install ~/Downloads/stencil-core-4.18.3-dev.1719242893.03e4c89.tgz