Closed tanner-reits closed 3 days ago
@stencil/core@4.19.0 ts tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts
--strictNullChecks
error reportTypechecking with --strictNullChecks
resulted in 1079 errors on this branch.
That's the same number of errors on main, so at least we're not creating new ones!
There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9699836753/artifacts/1645401635
If your browser saves files to ~/Downloads
you can install it like so:
unzip -d ~/Downloads ~/Downloads/stencil-core-4.19.0-dev.1719504056.dfa50d0.tgz.zip && npm install ~/Downloads/stencil-core-4.19.0-dev.1719504056.dfa50d0.tgz
What is the current behavior?
7ffb25d259de5b863e7dc3bc43270265cc786557 introduced a regression when generating the
components.d.ts
file. The logic for import aliasing did not account for external packages, resulting in broken import/export statements likeimport { as MyType } from 'external-package';
Fixes #5859
What is the new behavior?
The compiler will now generate a stub id for external packages so we can keep track of the original type name.
Documentation
N/A
Does this introduce a breaking change?
Testing
Verified fix on the reproduction case
Other information
This does technically change the output generated for the'
docs-json
output target. Previously, the id for imports in these cases would be an empty string, now it will be a mocked id in the form of `node_modules::