Closed christian-bromann closed 3 days ago
@stencil/core@4.19.0 ts tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts
--strictNullChecks
error reportTypechecking with --strictNullChecks
resulted in 1079 errors on this branch.
That's the same number of errors on main, so at least we're not creating new ones!
There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9700423118/artifacts/1645564294
If your browser saves files to ~/Downloads
you can install it like so:
unzip -d ~/Downloads ~/Downloads/stencil-core-4.19.0-dev.1719506672.cc0a1d8.tgz.zip && npm install ~/Downloads/stencil-core-4.19.0-dev.1719506672.cc0a1d8.tgz
What is the current behavior?
We have received feedback that people were running into type issues with the
hydrateDocument
function resolving in returning aReadable
by default. This goes against our objective of supporting DSD without a breaking change.What is the new behavior?
Change the order of function overwrites to have TS resolve into a Promise first.
Documentation
Does this introduce a breaking change?
Testing
Added an e2e test for this.
Other information
Thanks @sean-perkins for the hint!