ionic-team / stencil

A toolchain for building scalable, enterprise-ready component systems on top of TypeScript and Web Component standards. Stencil components can be distributed natively to React, Angular, Vue, and traditional web developers from a single, framework-agnostic codebase.
https://stenciljs.com
Other
12.52k stars 782 forks source link

bug: latest puppeteer version does not work with Stencil built-in test runner #5984

Open verena-ifx opened 2 weeks ago

verena-ifx commented 2 weeks ago

Prerequisites

Stencil Version

4.12.0

Current Behavior

Running tests will lead to error messages for multiple tests, such as "App did not load in allowed time. Please ensure the content loads a stencil application. keep getting this when running my stencil tests" Once I downgrade to puppeteer v 21.9.0 again (which is no longer supported), all my tests pass.

Expected Behavior

Tests should pass and run fast on the latest puppeteer version used with stencil test runner

System Info

No response

Steps to Reproduce

Upgrade to latest puppeteer version (together with latest Stencil + Jest version)

Code Reproduction URL

s://github.com/Infineon/infineon-design-system-stencil/actions/runs/10855821161/job/30129205007

Additional Information

No response

tanner-reits commented 2 weeks ago

@verena-ifx We're aware of the issues with the latests versions of Puppeteer. There's an existing dependency update PR (https://github.com/ionic-team/stencil/pull/5982) for this, but we need to make some changes in Stencil as we're a few major versions behind at this point. However, at this time, we're not sure when we'll be able to schedule this work.

joshcrain commented 11 hours ago

@tanner-reits thanks for looking into this. We encountered the same issues as @verena-ifx when using Puppeteer v22 with the StencilJS test runner. Tests that previously worked with earlier versions of Puppeteer no longer function as expected.

Additionally, attempting to use Puppeteer v21 and below results in installation failures in our pipeline via npm. Puppeteer is aware if this bug. Puppeteer suggests upgrading to a newer version, but v22 does not work with the StencilJS test runner. We seem to be caught in a bit of a catch-22.

Local Environment: