search

ionic-team / vscode-extension

15 stars 0 forks source link

The plugin does not read the 'pnpm-workspace' file to detect the 'ionic-app' in the 'apps' folder. #144

Closed Roberto4091 closed 1 year ago

Roberto4091 commented 1 year ago

Hello, I'm using the latest version of the plugin v1.55.1 in a monorepo that works with pnpm, but the plugin can't find the app. From what I can see, it's reading the root's package.json file. I'm attaching screenshots

pnpm-workspace.yaml

packages:
  - 'apps/*'
  - 'packages/*'

Root structure

Screen Shot 2023-10-25 at 12 23 01 AM

App structure

Screen Shot 2023-10-25 at 12 23 14 AM

Result in plugin

Screen Shot 2023-10-25 at 12 23 33 AM

I also used the multi-workspace structure provided by Visual Studio Code, as I saw in the plugin documentation that it is supported, but the result was the same.

dtarnawsky commented 1 year ago

Thanks for the bug report @Roberto4091, the problem seems to be the single quotes ' in the folder names in pnpm-workspace.yaml. The extension was only supporting " double quotes or no quotes. In v1.56.0 the problem is fixed.