search

ionicc / Github-organization-inviter

Automate inviting users to your Github Organzation!
4 stars 7 forks source link

Check for username on GitHub before sending invitation. Fixes #8 #11

Closed Ryuno-Ki closed 5 years ago

Ryuno-Ki commented 5 years ago

During the work on this project I had some remarks. Are you open for filling issues on them?

ionicc commented 5 years ago

Absolutely @Ryuno-Ki 😄

Ryuno-Ki commented 5 years ago

I ran the program on my local machine (and spotted a security issue with GitHub). Personally, I'd say, the issue is not precise enough.

I'd expect the user to be informed somehow, that the username could not be found. The HTTP status code should be 400 then. The same behaviour should happen on empty username.

Right now, the implementation does not allow that.

I checked what happens if I enter an username like goawaynow. I execute the catch callback. If I enter an username like nobody, the then callback is executed.

In my opinion, this is what the issue is asking for. I'd fill follow-up tickets with general improvements.

Ryuno-Ki commented 5 years ago

I filled follow-up issues and linked them to #8