search

ionide / FSharp.Analyzers.SDK

Library for building custom analyzers for F# / FSAC
http://ionide.io/FSharp.Analyzers.SDK/
MIT License
74 stars 21 forks source link

Remove the condition on setting PackageLicenseExpression/PackageTags in directory.build.props #173

Closed Numpsy closed 9 months ago

Numpsy commented 9 months ago

refs https://github.com/ionide/FSharp.Analyzers.SDK/issues/33 where the license seems to not be getting applied to the packages due to the condition.

Alternatively the suggestion in https://github.com/ionide/FSharp.Analyzers.SDK/issues/33#issuecomment-1823079531 to move the logix into a directory.build.targets also seems to work, so I can do whichever one is prefered.

nojaf commented 9 months ago

Moving to directory.build.targets would be cleanest but it is not the end of the world that the sample projects get two more properties. I'm going to take this as is. Thanks @Numpsy