search

ionide / FSharp.Analyzers.SDK

Library for building custom analyzers for F# / FSAC
http://ionide.io/FSharp.Analyzers.SDK/
MIT License
74 stars 21 forks source link

Use `Microsoft.Extensions.Logging` instead of `printf` based logging infrastructure #175

Closed dawedawe closed 8 months ago

dawedawe commented 9 months ago

@baronfel Would be great, if you could maybe also take a look if this makes sense.

TheAngryByrd commented 9 months ago

I think the SDK/TestSDK needs to rely on the Microsoft.Extensions.Logging.Abstractions while the CLI can use the console logger.

dawedawe commented 9 months ago

I think the SDK/TestSDK needs to rely on the Microsoft.Extensions.Logging.Abstractions while the CLI can use the console logger.

Oh yeah, thanks @TheAngryByrd !

nojaf commented 9 months ago

FYI @dawedawe we are doing main now.

smoothdeveloper commented 8 months ago

hey, wondering if going this direction would pave way of doing cool things like https://github.com/dotnet/msbuild/tree/main/src/MSBuild/TerminalLogger achieved?

dawedawe commented 8 months ago

Thanks for the review. I tried vertical-spectreconsolelogger but would prefer to wait for it to mature some more.