ionide / FSharp.Analyzers.SDK

Library for building custom analyzers for F# / FSAC
http://ionide.io/FSharp.Analyzers.SDK/
MIT License
74 stars 21 forks source link

Use ilogger colorized prettyprint and analyzer uri #180

Open smoothdeveloper opened 8 months ago

smoothdeveloper commented 8 months ago

redo #174/#176 on top of @dawedawe #175 (this PR should only show my commit(s) once #175 is merged I think).

I'm not sure how to check the mode that is not using the command line, but I assume; the integration into MSBuild, so please let me know if adjustments are needed there and how I should invoke it in a custom project.

This does two things:

image

Regarding how I initially did it and now, I see we use "vanilla .NET string formatting" instead of interpolation or fsharp formatting specifyier which enforces there are matching arguments.

I was wondering if this was important to use this less safe way due to relying on the logging infrastructure changes done in #175 or we can reconsider going through F# format specifiers without losing on the logging infrastructure integration?

smoothdeveloper commented 8 months ago

after rebasing all seems consistent (including what fantomas formatted, versus comment), let see if this gets green.

dawedawe commented 8 months ago

While I like the change, I don't really want to take the risk for the release of the current week. So let's investigate what's going wrong here without rush.

smoothdeveloper commented 8 months ago

No hurries, no worries :)