Add RequireQualifiedAccess to Severity type

ionide / FSharp.Analyzers.SDK

Library for building custom analyzers for F# / FSAC

http://ionide.io/FSharp.Analyzers.SDK/

MIT License

74 stars 21 forks source link

Add RequireQualifiedAccess to Severity type #199

Closed Smaug123 closed 7 months ago

Smaug123 commented 7 months ago

We currently export the DU case Error, which clashes with FSharp.Core's Result.Error. This change means we never conflict with FSharp.Core. The change is source-incompatible, so it will require a release note.

nojaf commented 7 months ago

Could you check https://github.com/ionide/FSharp.Analyzers.SDK/blob/main/docs/content/Getting%20Started%20Writing.fsx ? It probably needs a change as well.

Smaug123 commented 7 months ago

Yep, thanks - I can't run this locally easily because I don't have net7 installed, so I'm using GitHub to do it (sorry).

nojaf commented 7 months ago

Hmm, fsdocs-tool should be net6.0 though. Perhaps you need 7 for other stuff.

Smaug123 commented 7 months ago

The specific reason is this line. But I'm happy now that this PR is ready.