search

ionide / Fornax

Scriptable static site generator using type safe F# DSL to define page templates.
MIT License
244 stars 44 forks source link

Update to .NET 5 #78

Closed laenas closed 3 years ago

laenas commented 3 years ago

I think this pushes it forward (and closes out #77)- though I want to call a little attention to the targetting of Fornax.Core - which I have left at netstandard2.0 - as pushing it to net5.0 has implications for things like FSIRefs and its (current - 2) version compatibility handling.

That said, if we want to burn our ships on the shore of .NET 5, it's an easy enough update to the PR! 😉

laenas commented 3 years ago

Prior to opening the PR, I was waffling a bit on that netstandard / net5.0 switch - and ran stuff locally under net5.0, before switching it up for the PR. Having sorted out the cause of that initial failed build, I figured I'd take a peek, and it sure does seem like without Core being targeted to net5.0, we don't get support for stuff like #r "nuget: Package" support.

Is there a way around this that I'm not immediately seeing? :)

The after-more-tinkering edit: This might not actually be an issue afterall. I'd been debugging against another local fornax site, previously generated, and that seems to have been the core issue, not the usage of netstandard. At least, checked against debugging the local /samples/ which specifies the netstandard2.0 Fornax.Core in its #r directive.

baronfel commented 3 years ago

It's fine to bump to net5.0, that's required for latest FCS anyway.

baronfel commented 3 years ago

@laenas after you've done this, have you been able to install the generated package locally for testing and such?

laenas commented 3 years ago

@baronfel

Update CHANGELOG to insert a new (fake) version line dotnet fake build -T Pack Move the .nupkg from /out/ to my local nuget cache location dotnet tool install -g Fornax --version (my fake version) tweak the sample site in /samples/ to use an #r "nuget: " reference and a $"{}" interpolation to add NET5 / F# 5 specific features. fornax watch Site generates as expected

baronfel commented 3 years ago

Thanks!