ionide / FsAst

http://blog.ctaggart.com/2014/09/generating-f-code-using-its-ast.html
MIT License
48 stars 15 forks source link

New versions of Fantomas require trivia to have some value #44

Open UnoSD opened 2 years ago

UnoSD commented 2 years ago

Is your feature request related to a problem? Please describe. After updating Myriad (and consequently Fantomas), all the generated code misses keywords, turns out new Fantomas versions require a non-None value for trivia, but most of the helpers generate it with None, causing all the generated AST to produce nonsense code.

Describe the solution you'd like Can all the default record and helper methods generate trivia with Some Range.Zero by default?

Describe alternatives you've considered Dropping FsAst and re-writing all the code to create unions directly Cloning the repository and making the changes myself and reference locally

Additional context Please see here: https://github.com/MoiraeSoftware/myriad/issues/154 Started playing with it here: https://github.com/ionide/FsAst/commit/a6649ec1a49f004e1769cb75df3928fc822c96c8

Thank you.