ionide / FsAutoComplete

F# language server using Language Server Protocol
Other
391 stars 151 forks source link

Remove older impls #1174

Closed TheAngryByrd closed 8 months ago

TheAngryByrd commented 9 months ago

WHAT

๐Ÿค– Generated by Copilot at 0919866

Removed the NamedText type and related code from the project and replaced it with more efficient and consistent source text implementations. Simplified the LSP server implementation and the code fix scaffolding process. Updated the documentation and tests accordingly.

๐Ÿค– Generated by Copilot at 0919866

We're sailing on the Roslyn sea, with adaptive LSP We've left behind the NamedText, it was a heavy mess So heave away, me hearties, heave away with glee We'll test our code fixes with any IFSACSourceText

๐Ÿš€๐Ÿงน๐Ÿ“

WHY

We've been running on newer implementations for a while and seems to be time to clean up older implementations.

Should I also remove any of the "seams" I put in like IFSACSourceText?

I also haven't refactored AdaptiveLSP just yet.

HOW

๐Ÿค– Generated by Copilot at 0919866

Krzysztof-Cieslak commented 9 months ago

Should I also remove any of the "seams" I put in like IFSACSourceText?

yeah, I think so.

Krzysztof-Cieslak commented 9 months ago

I also haven't refactored AdaptiveLSP just yet.

That's fine; let's do it in separate PR, and focus this one on just removing things.