Closed TheAngryByrd closed 8 months ago
Should I also remove any of the "seams" I put in like IFSACSourceText?
yeah, I think so.
I also haven't refactored AdaptiveLSP just yet.
That's fine; let's do it in separate PR, and focus this one on just removing things.
WHAT
๐ค Generated by Copilot at 0919866
Removed the
NamedText
type and related code from the project and replaced it with more efficient and consistent source text implementations. Simplified the LSP server implementation and the code fix scaffolding process. Updated the documentation and tests accordingly.๐ค Generated by Copilot at 0919866
๐๐งน๐
WHY
We've been running on newer implementations for a while and seems to be time to clean up older implementations.
Should I also remove any of the "seams" I put in like
IFSACSourceText
?I also haven't refactored AdaptiveLSP just yet.
HOW
๐ค Generated by Copilot at 0919866
NamedText
type and its dependencies from the code base, replacing it with theRoslynSourceText
type that implements theIFSACSourceText
interface more efficiently and consistently (link, link, link, link, link)FsAutoComplete.Lsp.fs
file and theFSharpLspServer
type, and using theAdaptiveFSharpLspServer
type instead (link, link, link, link, link, link, link, link, link)FsAutoComplete.Lsp.fs
file from the registration of the code fix (link, link, link, link, link, link, link)HelpersTests
and theTests
modules in thetest/FsAutoComplete.Tests.Lsp
project to take atextFactory
argument of typeISourceTextFactory
to allow testing different implementations of theIFSACSourceText
interface (link, link, link, link, link, link, link)initNamedText
andaddToNamedText
functions from theHelpers
module in the./benchmarks/SourceTextBenchmarks.fs
file, and the irrelevantNamed_Text_changeText_everyUpdate
benchmark from theSourceText_LineChanges_Benchmarks
type in the same file (link, link, link)