ionide / FsAutoComplete

F# language server using Language Server Protocol
Other
391 stars 151 forks source link

Dotnet 8 builds #1175

Closed TheAngryByrd closed 8 months ago

TheAngryByrd commented 8 months ago

WHAT

πŸ€– Generated by Copilot at 511ea16

This pull request updates the project to support the experimental net8.0 target framework, using a new environment variable BuildNet8 to control the compilation. It also fixes some JSON and line ending issues, removes unused tools, and updates dependencies.

πŸ€– Generated by Copilot at 511ea16

net8.0 support added with conditions and tools autumn of .NET

πŸŽ―πŸ› οΈπŸ§ͺ

WHY

Might as well see what CI says.

HOW

πŸ€– Generated by Copilot at 511ea16

TheAngryByrd commented 8 months ago

Hmm looks like 8rc2 is broke with tools https://github.com/dotnet/sdk/issues/35989

Guess we'll try rc3.

baronfel commented 8 months ago

@TheAngryByrd I think I've fixed the fantomas problems - they were actually because while fantomas did have a RollForward of major, the 8.x version is technically a prerelease - once I added the env var to allow prereleases to participate in rollfoward the tool began working. I think this is a UX bug and I'm going to ask Rich Lander's team to consider expanding the set of allowed SDKs/runtimes.