search

ionide / FsAutoComplete

F# language server using Language Server Protocol
Other
412 stars 154 forks source link

integration of analyzers #1200

Closed dawedawe closed 10 months ago

dawedawe commented 10 months ago

WHAT

🤖 Generated by Copilot at 363b94e

This pull request adds the Ionide.Analyzers package as a dependency and a tool to the FsAutoComplete solution, and configures the GitHub workflow and the custom targets to run the analyzers on the code base. This improves the quality and consistency of the F# code in the project.

🤖 Generated by Copilot at 363b94e

Ionide.Analyzers Helps FsAutoComplete shine Code fixes in spring

🛠️🔎🧹

WHY

Let's integrate the Ionide analyzers in brotherly love. ~~The $(PkgIonide_Analyzers) property seems to be empty (all others, too) when used in the target by MSBuild. Maybe because we use paket... Even though the nuget.g.props file looks good 🤷 Let's see what CLI says.~~

HOW

🤖 Generated by Copilot at 363b94e

github-advanced-security[bot] commented 10 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

baronfel commented 10 months ago

@dawedawe can you resolve the paket.dependencies conflict? this is good to take whenever that's resolved.

dawedawe commented 10 months ago

Thanks for the reviws. To deal with the nuget security warnings which are now handled as errors I pinned the versions of