ionide / FsAutoComplete

F# language server using Language Server Protocol
Other
391 stars 151 forks source link

Drop ISourceTextFactory/IFSharpLspServer from test names #1205

Closed dawedawe closed 7 months ago

dawedawe commented 7 months ago

…codebase, let's have simpler test names

WHAT

🤖[deprecated] Generated by Copilot at e9f83ce

This pull request simplifies and refactors the LSP test code by using a consistent RoslynSourceTextFactory for creating source texts and removing unnecessary parameters and test cases. It affects the files InlayHintTests.fs, Program.fs, and FindReferencesTests.fs.

🤖[deprecated] Generated by Copilot at e9f83ce

We are the Roslyn legion, we forge the source of truth We purge the useless parameters, we streamline the test of proof We unify the LSP server, we crush the code complexity We are the Roslyn legion, we reign in text analysis

🔥🎨🔧

WHY

Now wIth only one ISourceTextFactory and one IFSharpLspServer implementation in the codebase, let's have simpler test names. Of course, this only makes sense without plans to have multiple implementations again. If there are plans, ignore this PR :)

HOW

🤖[deprecated] Generated by Copilot at e9f83ce

dawedawe commented 7 months ago

Good question. The failings are jumping randomly between 6/7/8 and OS. So my guess is something funky on the GH instances. But I have no idea how to debug this further.