search

ionide / FsAutoComplete

F# language server using Language Server Protocol
Other
389 stars 151 forks source link

Additional warn on #1207

Closed nojaf closed 7 months ago

nojaf commented 7 months ago

WHAT

🤖[deprecated] Generated by Copilot at ad118b4

This pull request improves the code quality, readability, and performance of the FsAutoComplete language server by simplifying and cleaning up various pattern matching expressions, removing unused or redundant parameters, variables, and bindings, updating the FCS dependency, adding a new benchmark, and enabling some compiler warnings. The affected files include SourceText.LineChanges, AbstractClassStubGenerator, AdaptiveExtensions, Commands, CompilerServiceInterface, DocumentationFormatter, FCSPatches, InlayHints, ParseAndCheckResults, State, TypedAstPatterns, UnionPatternMatchCaseGenerator, build/Program.fs, Directory.Build.props, CodeGeneration, Debug, DotnetNewTemplate, Fsdn, and TypedAstUtils.

🤖[deprecated] Generated by Copilot at ad118b4

We are the wildcards of the code We simplify the patterns of the mode We remove the bindings of the dead We improve the quality of the shred

🧹🚀🛠️

WHY

HOW

🤖[deprecated] Generated by Copilot at ad118b4

I'd like to enable warnings on FS1182. https://github.com/fsharp/FsAutoComplete/pull/1206/commits/0297edacc31b7fe6d9be279031518bf64401c2af would have been discovered instantly if this was enabled.

baronfel commented 7 months ago

Thanks for doing this code cleanup :)

nojaf commented 7 months ago

Thank you Chester! For everything!