search

ionide / FsAutoComplete

F# language server using Language Server Protocol
Other
389 stars 151 forks source link

Update analyzers support #1217

Closed dawedawe closed 5 months ago

dawedawe commented 6 months ago

This updates the analyzers support to the latest SDK. We have two analyzer collections ready to use:

Some analyzers come with fixes. See videos below. Users can filter with the new settings FSharp.excludeAnalyzers xor FSharp.includeAnalyzers which analyzers they want to exclude or include in their experience. In a certain way, this concludes all the work that was invested in the analyzers over the last couple of months. Thanks to everyone involved 🚀

https://github.com/fsharp/FsAutoComplete/assets/3221269/af4cfa5c-1151-4d3f-a2a2-0fb9eda04343

https://github.com/fsharp/FsAutoComplete/assets/3221269/39eedaed-246c-4707-9aae-e9fe8ce46845

dawedawe commented 5 months ago

LGTM, but have you seen the Ubuntu format error? It's been happening somewhat frequently but I haven't been able to figure out how to reproduce it.

Thanks for the review. Yes, I've seen that in the past and also banged my head against it. But no luck :( I'll try again in the next couple of days.

TheAngryByrd commented 5 months ago

Thanks @dawedawe and @nojaf!