Update logic and models to use Ionide.LanguageServerProtocol types generated from LSP metamodel

ionide / FsAutoComplete

F# language server using Language Server Protocol

Other

385 stars 151 forks source link

Update logic and models to use Ionide.LanguageServerProtocol types generated from LSP metamodel #1301

Closed baronfel closed 2 weeks ago

baronfel commented 1 month ago

We're now fully updated to using the generated types. The primary impactful changes are

uint32s virtually everywhere for positions/offsets (which per spec cannot be negative)
no more aliased types for several un-tagged unions (for example, MarkedString) - these now use the U2.C1, U2.C2, etc case constructors directly

baronfel commented 1 month ago

Only 10 tests failing now!

baronfel commented 1 month ago

@TheAngryByrd do you have any tips for debugging timing issues in the tests? Some of the tests are around completions, and it seems like this order of operations isn't occurring like expected:

textDocument/didOpen
textDocument/didChange
- leads to re-typecheck
textDocument/completion
- checks against stale typecheck therefore no/incorrect completions at expected location

TheAngryByrd commented 1 month ago

textDocument/didOpen textDocument/didChange

I think a lot of unintended problems stem from "notifications" like theres were we don't return anything to the client and only are able to log errors. And if these don't happen, nothing else will work. Turning on debug logs is the only way unless we somehow get to a point where we can collect Traces/Logs per test.