ionide / FsAutoComplete

F# language server using Language Server Protocol
Other
385 stars 151 forks source link

Don't alert users about fsiExtraParameters if no actual parameters are passed #1305

Closed baronfel closed 2 weeks ago

baronfel commented 2 weeks ago

When working on https://github.com/ionide/ionide-vscode-fsharp/pull/2016, which exposes the new FSI extra parameters options from FSAC 0.73.1, I found the FSAC would always alert users even if no settings were passed on the fsiExtraParameters object. I think this is a serialization quirk, but since it's easy to detect empty arrays and ignore them, I've done so to prevent annoying users.