ionide / Ionide-vim

F# Vim plugin based on FsAutoComplete and LSP protocol
MIT License
174 stars 21 forks source link

`FsAutocomplete` no longer supports the `--enable-background-services` flag #61

Closed OmanF closed 1 year ago

OmanF commented 1 year ago

Describe the bug The instructions call for setting the plugin with the flag --enable-background-services (both locally, and globally, installed FsAutocomplete), however when running fsautocomplete from the CLI, it errors, showing the flag is no longer supported.

As a result, the plugin doesn't trigger LSP integration with NVIM.

To Reproduce Steps to reproduce the behavior:

  1. Follow installing the plugin (Ionide-vim) according to the README file.
  2. Make sure to set the correct behavior for the fsharp#fsautocomplete_command section of the settings, according to whether you have fsautocomplete installed locally or globally.

Expected behavior No errors in the plugin integration with both fsautocomplete and Nvim.

Environment (please complete the following information):

Additional context For some reason, when opening .fs or .fsx, or .fsi files, Nvim's built-in LSP client recognizes them as Forth files, not F# ones.

baronfel commented 1 year ago

That flag was removed in recent versions of FSAC - it was used to spawn a background check process that was removed from the service. It should be removed from the command spawn args if possible.

OmanF commented 1 year ago

I'll describe what I've tried and my Nvim config:

This covers both behaviors: local, and globally installed fsautocomplete. As I said, neither integrates well, and the LSP client says the .fs file is a Forth file.

(Let me know what more needs testing. :D)

OmanF commented 1 year ago

I've done a lot of dotnet paket install-ing today, and, while I don't know what exactly was the issue that was fixed by which package... apparently this issue is a non-issue and my mistake.

None the less, with regards to the --enable-background-services flag which was removed:

The plugin is working for me just fine. Closing and thanks to Cannonarin and Chet Husk (Baronfel) for their comments and work.