ionide / ionide-analyzers

http://ionide.io/ionide-analyzers/
MIT License
6 stars 7 forks source link

Unsafe option unwrapping analyzer #33

Closed sheridanchris closed 9 months ago

sheridanchris commented 9 months ago

Generalizes the existing analyzer to cover ValueOption and .Value member access Reference issue: #31

sheridanchris commented 9 months ago

Is Severity.Hint appropriate for this analyzer? Should this be a warning instead?

nojaf commented 9 months ago

Is Severity.Hint appropriate for this analyzer? Should this be a warning instead?

That is a tricky thing, I would be ok with warning here. Users can always change this via: image

nojaf commented 9 months ago

Thank you!