ionide / ionide-fsgrammar

Shared Textmate Regex Style F# Language Grammar
MIT License
35 stars 36 forks source link

Multiline comments captures too greedily #165

Closed catfly1 closed 2 years ago

catfly1 commented 2 years ago

Describe the bug Prior to a recent update, the following code was correctly syntax highlighted by ionide, but now it appears to treat the proceeding definitions as half comment. This causes issues for projects using fsdocs, which make extensive use of multiline comment to perform doc operations.

(*** hide ***)
System.IO.Directory.SetCurrentDirectory __SOURCE_DIRECTORY__
#load @"../../../bootstrap/references.fsx"
open Refs

Screenshots In summary it currently looks like this: after

When it used to look like this (for the same comment style): clean

Environment (please complete the following information):

catfly1 commented 2 years ago

Potentially related fix: https://github.com/ionide/ionide-fsgrammar/pull/164/files

MangelMaxime commented 2 years ago

I confirm that #164 fix this problem

MangelMaxime commented 2 years ago

@baronfel @selketjah

This issue can be closed as #164 has been merged.

baronfel commented 2 years ago

Thanks, will do 👍