search

ionide / ionide-fsgrammar

Shared Textmate Regex Style F# Language Grammar
MIT License
35 stars 36 forks source link

Rogue `"begin/endCaptures"` #206

Open RedCMD opened 7 months ago

RedCMD commented 7 months ago

There is a rogue "beginCaptures" with no "begin" rule should it be "captures"? https://github.com/ionide/ionide-fsgrammar/blob/472c6b2030c962217cbbb26e4ddcce1b8ffe0867/grammars/fsharp.json#L530

also a rogue "endCaptures" with no "end" rule should it be "whileCaptures"? https://github.com/ionide/ionide-fsgrammar/blob/472c6b2030c962217cbbb26e4ddcce1b8ffe0867/grammars/fsharp.json#L545

MangelMaxime commented 7 months ago

The first one should probably be "captures"

For the second one, yes probably. I can't find a documentation related to the TextMate grammar syntax on VSCode site.

RedCMD commented 7 months ago

yeah documentation around TextMate is very unpolished and fragmented

heres a little snippet on "while" https://github.com/jeff-hykin/better-cpp-syntax/blob/fe873cdfacd1df7072e7b8c95df3df369c1ffcaa/documentation/library/textmate_while.md

"whileCaptures" acts the same as "endCaptures"; but for the "while" rule instead