ionide / ionide-vscode-fsharp

VS Code plugin for F# development
http://ionide.io
MIT License
859 stars 277 forks source link

Unknown workspace edit change received: #1385

Closed mastoj closed 2 years ago

mastoj commented 4 years ago

Trying to use "ctrl+." to add the open statement for a namespace but nothing happens. The error message is:

Unknown workspace edit change received

Script file looks like:

#load ".paket/load/netcoreapp3.1/Snowflake.Data.fsx"

open Snowflake.Data
//open Snowflake.Data.Client

let test() =
    let connection = SnowflakeDbConnection()
    ()

test()

Paket.dependencies:

source https://api.nuget.org/v3/index.json

storage: none
framework: netcoreapp3.1, netstandard2.0, netstandard2.1
nuget Snowflake.Data

Let me know if more input is needed to triage this.

open-collective-bot[bot] commented 4 years ago

Hey @mastoj :wave:,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our OpenCollective and consider backing us.

https://opencollective.com/ionide

PS.: We offer backer support for all backers. Don't forget to add backer label when you start backing us :smile:

Krzysztof-Cieslak commented 3 years ago

Hey, @baronfel have we talked about it recently or memory fails me?

baronfel commented 3 years ago

Is this issue something like:

@Krzysztof-Cieslak I think we've been talking about instances where the codefix doesn't trigger at all (needs upstream fixes) vs instances where the codefix is triggered and fails

Krzysztof-Cieslak commented 3 years ago

Unknown workspace edit change received

suggest that we send the edit but it's somehow wrong, maybe wrong range due to script file or something?

seanamos commented 3 years ago

I occasionally receive this in some files when using symbol renames (F2) as well. There will just be some files where it doesn't work.

baronfel commented 3 years ago

This is probably because workspaceEdits often require the version to be present and we weren't always honoring this. See https://github.com/rust-analyzer/rust-analyzer/issues/6654#issuecomment-735980787 for details, and https://github.com/fsharp/FsAutoComplete/pull/816 for our version of the same fix.