search

ionide / ionide-vscode-fsharp

VS Code plugin for F# development
http://ionide.io
MIT License
865 stars 279 forks source link

Missing Error Highlighting in Erroneous Code #1602

Closed sebastto closed 2 years ago

sebastto commented 3 years ago

Describe the bug**

The code in the attached gist is erroneous , yet Ionide-fsharp is unable to highlight the errors before running the code. There is both an issue in the pattern match expression and when calling the custom option map function with a regular string.

Steps to reproduce

  1. Open an F# interactive script in VSCode
  2. Copy code from gist
  3. Select and run code in F# Interactive mode (alt + enter)

Link to sample reproduction

https://gist.github.com/sebastto/dc11b5cffc90625cccdd054017ab47f2

Expected behaviour

Expected the errors to be highlighted before running the code. When writing the same script in Visual Studio, the error is detected before running, see attached screenshot.

Screenshots

Screenshot from Visual Studio image

Machine info

open-collective-bot[bot] commented 3 years ago

Hey @sebastto :wave:,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our OpenCollective and consider backing us.

https://opencollective.com/ionide

PS.: We offer backer support for all backers. Don't forget to add backer label when you start backing us :smile:

isaacabraham commented 2 years ago

Also seeing this in latest Ionide with .NET 6 for even trivial scripts. The following invalid F# shows no errors in the code editor.

let x = 123jfdsj

.NET 6.0 on Windows 11, v5.10.2.

Krzysztof-Cieslak commented 2 years ago

Everything seems to be working fine for me:

image