ionide / ionide-vscode-fsharp

VS Code plugin for F# development
http://ionide.io
MIT License
858 stars 277 forks source link

Reduce friction #1918

Closed stroborobo closed 1 year ago

stroborobo commented 1 year ago

WHAT

šŸ¤– Generated by Copilot at 3d47f79

This pull request updates various files related to the project's build, formatting, and configuration. It requires the .NET 7 SDK for building the project and adds the MSBuild.StructuredLogger package for parsing the build logs. It also removes an unnecessary flag from the fantomas command, adds the rollForward property to the global.json file, and syncs the .editorconfig and .gitattributes files. Finally, it updates the wsconfig.json schema file to include the dce option for the WebSharper compiler.

šŸ¤– Generated by Copilot at 3d47f79

global.json changed roll forward to latest features autumn of .NET

:memo::wrench::sparkles:

WHY

I wanted to look into the new test discovery feature, but had some issues to get started. Like missing the exact dotnet version or fantomas/editorconfig and git not agreeing on line endings, causing changes where there should be none. So I tried to reduce the friction I experienced.

I don't know if these changes are in your interest, since they could be disruptive. For existing checkouts on non-Windows platforms for example, you'd need to delete and checkout all your files for the .fs CRLF change to be applied like this: git rm -rf --cached . && git reset --hard HEAD. (Destructive action! Commit first.)

HOW

šŸ¤– Generated by Copilot at 3d47f79

stroborobo commented 1 year ago

Hey this Copilot for PRs is neat. Didn't change the actual content of wsconfig.json though, just line endings through the tool:
git add --renormalize .