ionide / ionide-vscode-fsharp

VS Code plugin for F# development
http://ionide.io
MIT License
850 stars 276 forks source link

Bug xunit theory #1936

Closed farlee2121 closed 9 months ago

farlee2121 commented 9 months ago

WHAT

1935

Parameterized tests were never finishing for xUnit and MSTest. This gets them completing properly.

HOW

Piece together consistent fully qualified test names from different fields based on the test framework.

Merge?

I'm not sure if this PR is worth merging yet. It does get parameterized tests completing and status showing across xUnit, nUnit, MSTest, and expecto.

However, MSTest and xUnit still can't individually run the theory cases (some kind of filter issue), and the theory cases aren't nested under their shared method. This makes it a impossible to run the theory test without running a larger grouping of tests.

farlee2121 commented 9 months ago

There aren't any clear wholistic solutions to the issues with parameterized tests. It might take me a while to get a good solution out there. Therefore, I think it's worth getting this change out so users can at least run test suites including parameterized tests

TheAngryByrd commented 9 months ago

Might be worth opening issues on the respective frameworks asking questions of how to get at them.

Also maybe we should have it documented the features/limitations of each framework currently.