New tests not detected - Githubissues

nojaf commented 3 months ago

Describe the bug

When adding a new unit test in an existing file, the new test does not get picked up.

Steps to reproduce

Try cloning https://github.com/fsprojects/fantomas
Open project and file src\Fantomas.Core.Tests\Stroustrup\SynBindingFunctionExpressionTests.fs
Wait until you can see test icon for existing tests
add a new test like [<Test>] let foo () = ()

Expected behaviour

The new test gets picked up.

Screenshots

Machine info

OS: Windows
.NET SDK version: 8.0.202
Ionide version: v7.18.2

Additional context

I noticed @farlee2121 changed the way unit tests are detected in https://github.com/ionide/ionide-vscode-fsharp/pull/1874. There no longer seems to be any notification coming from the LSP server.

Is the file being watched for changes? I can't really find any evidence for this in the current code.

farlee2121 commented 3 months ago

It still uses the same LSP code analysis notifications for live updates as before. It now routes through a mailbox to resolve concurrency issues . The main handler is onTestsDiscoveredInCode

nojaf commented 3 months ago

Hmm, when attaching to FSAC, I see that I get an exception from:

The test is found but I suspect the notification is not getting to the client.

@baronfel, shot in the dark: is FSharpSignatureData trying to resolve a symbol with cached checking information? As it is failing for newly typed code that would be my guess.

ionide / ionide-vscode-fsharp

New tests not detected #1997