search

ionide / ionide-vscode-fsharp

VS Code plugin for F# development
http://ionide.io
MIT License
862 stars 279 forks source link

FSI send ignore comments #1859 #2049

Open jkone27 opened 1 week ago

jkone27 commented 1 week ago

fixes issue with comments too long , partial fix for general issue 1859, to avoid FS0193: operation not supported

image

but comments can be safely ignored and skip FSI send, even if very long

image

baronfel commented 1 week ago

@vzarytovskii you make a good point about the compensation - right now the closest thing we have to an 'in-editor' link is the fact that some terminals will look for things that look like a file path/line/column and will auto-link to it. VSCode does do this, so the line numbers might be a bit off.

This is something that would be fixed for real if Ionide managed FSI sessions interactively via the FCS APIs instead of by 'driving' dotnet fsi instances.

vzarytovskii commented 1 week ago

@vzarytovskii you make a good point about the compensation - right now the closest thing we have to an 'in-editor' link is the fact that some terminals will look for things that look like a file path/line/column and will auto-link to it. VSCode does do this, so the line numbers might be a bit off.

This is something that would be fixed for real if Ionide managed FSI sessions interactively via the FCS APIs instead of by 'driving' dotnet fsi instances.

The "cheapest" solution might be is to not remove comments, but strip them to just //, it will preserve lines, but no need for maintaining offsets.