search

ionide / ionide-vscode-mechanic

Mechanic plugin for VS Code
https://github.com/fsprojects/Mechanic
MIT License
17 stars 4 forks source link

Use ionide api #2

Closed Krzysztof-Cieslak closed 6 years ago

Krzysztof-Cieslak commented 6 years ago

Adds integration with Ionide-fsharp to get list of projects instead of finding them manually. Thanks to that we have access to full information about the projects, which enables us to detection project to which current file belongs etc.

forki commented 6 years ago

@MangelMaxime I talked with @Krzysztof-Cieslak about this. I think it's fine to depend on ionide being installed.

Krzysztof-Cieslak commented 6 years ago

I've added Ionide-fsharp as extension dependency which means it will be installed while Mechanic installation if someone hadn't have it, and ensures that activation is in correct order - https://github.com/ionide/ionide-mechanic/pull/2/files#diff-063a4bb40919e286740e859acee5eb3eR27

MangelMaxime commented 6 years ago

I didn't know we could do that and I am ok with this changes. It's seems logic to do that.