search

ionide / ionide-vscode-mechanic

Mechanic plugin for VS Code
https://github.com/fsprojects/Mechanic
MIT License
17 stars 4 forks source link

Show in the status bar that Mechanic is running ? #5

Closed MangelMaxime closed 6 years ago

MangelMaxime commented 6 years ago

When Ionide is loading F# project, it display a little text and animation in the status bar. We probably should do that when running Mechanic too so users don't have the feeling it's doing nothing.

forki commented 6 years ago

currently mechanic opens in new window for me. /cc @Krzysztof-Cieslak

MangelMaxime commented 6 years ago

@forki It's starting a new terminal ?

Could you please do a gif because I don't have this behavior ?

forki commented 6 years ago

I'm on windows. maybe that's why?

MangelMaxime commented 6 years ago

I think it's the reason but would be better to have the same behavior across the OS :)

Krzysztof-Cieslak commented 6 years ago

Mechanic is not opening new window for me, tho I'm on Linux at the moment. Also, I think it shouldn't open any new window.

To get this text + animation we use Progress API - window.withProgress function. Example: https://github.com/ionide/ionide-vscode-fsharp/blob/f64c58901851ed7b2d88f3c485b2d3082011b3c1/src/fsharp.fs#L33-L35

forki commented 6 years ago

mechanic

forki commented 6 years ago

image

seems to fix it - should I remove that flag?

MangelMaxime commented 6 years ago

I don't like removing this flag because then it's opening a new termial in VSCode.

I have an extensio doing that and it's really annoying because it's mask my active terminal. I propose to remove the flag on windows only ?

forki commented 6 years ago

ok. can you please do that?

MangelMaxime commented 6 years ago

Sure will do, I am trying to fix something else. Loading the project using Ionide seems broken for me, I am trying to understand.

MangelMaxime commented 6 years ago

Finally, removing shell on OS X don't open the new terminal windows so I just remove the option all the time.