ionide / ionide-vscode-paket

VS Code plugin for Paket
http://ionide.io
MIT License
40 stars 29 forks source link

WIP: Creating a FAKE script to publish to VS Code gallery #5

Closed forki closed 8 years ago

forki commented 8 years ago

Implements https://github.com/ionide/ionide-vscode-paket/issues/4

Krzysztof-Cieslak commented 8 years ago

I think local npm installation (obtained by Paket from NuGet can be uesd on Windows) - https://github.com/FractalProject/Fractal.Sample/blob/master/build.fsx#L42-L45

forki commented 8 years ago

Awesome ;-) On Nov 19, 2015 12:13 PM, "Krzysztof Cieślak" notifications@github.com wrote:

I think local npm installation (obtained by Paket from NuGet can be uesd on Windows) - https://github.com/FractalProject/Fractal.Sample/blob/master/build.fsx#L42-L45

— Reply to this email directly or view it on GitHub https://github.com/ionide/ionide-vscode-paket/pull/5#issuecomment-158025773 .

Krzysztof-Cieslak commented 8 years ago

Also, preferably during deploy process I would want to publish plugin to extension gallery but also do GitHub release of packed version (using vsce package)

forki commented 8 years ago

image

forki commented 8 years ago

waiting for https://github.com/Microsoft/vscode-vsce/pull/47 to get merged and released ;-)

forki commented 8 years ago

done!

see https://github.com/ionide/ionide-vscode-paket/releases/tag/1.0.2

forki commented 8 years ago

This is my release.cmd (minus passwords). It's already in gitignore.

    @echo off
    cls

    .paket\paket.bootstrapper.exe
    if errorlevel 1 (
    exit /b %errorlevel%
    )

    .paket\paket.exe restore
    if errorlevel 1 (
    exit /b %errorlevel%
    )
    packages\FAKE\tools\FAKE.exe build.fsx "target=Release" "vsce-publisher=mypublisher" "vsce-token=mykey" "github-user=myuser" "github-pw=mypw"
Krzysztof-Cieslak commented 8 years ago
  1. VSCE path is hard coded to your path, I wonder if we could use %APPDATA% to get C:\Users\Steffen\AppData\Roaming this part of VSCE path.
  2. I'm not sure if InstallVSCE and loginToVSCE should part of normal release cycle - those operations have to be done only once per machine, so while it is useful to have them in build script, i would not include them in normal release path, but rater create target Setup which will just run those 2.
forki commented 8 years ago
  1. Oups. fixed
  2. Mhm these targets run for only two seconds. It makes it really convenient ;-)
Krzysztof-Cieslak commented 8 years ago

Well, we don't know how vsce login will behave. I think it is asking for confirmation in case of relogging.

forki commented 8 years ago

Yeah we can decide later. At the moment it's not in standard pipeline. On Nov 20, 2015 14:36, "Krzysztof Cieślak" notifications@github.com wrote:

Well, we don't know how vsce login will behave. I think it is asking for confirmation in case of relogging.

— Reply to this email directly or view it on GitHub https://github.com/ionide/ionide-vscode-paket/pull/5#issuecomment-158404925 .

Krzysztof-Cieslak commented 8 years ago

OK, so let's do this ;)