ionide / proj-info

Parse and evaluate MsBuild project files
MIT License
64 stars 37 forks source link

check file paths for probed environment variables for existence #190

Closed baronfel closed 1 year ago

baronfel commented 1 year ago

WHAT

🤖 Generated by Copilot at 8704a72

The pull request updates the dotnet-tools.json file to use the latest tools and adds a new function checkExistence to the Utils.fs file to simplify file existence checks. These changes enhance the project's reliability and code quality.

🤖 Generated by Copilot at 8704a72

Oh we're the merry coders of the F# crew We update our tools and refactor too We use checkExistence to make our code neat And we heave away on the count of three

:arrow_up::wrench::recycle:

WHY

Fixes a validation gap described in https://github.com/fsharp/FsAutoComplete/issues/1014#issuecomment-1542429111 - we check PATH and the 'default' locations for the existence of the actual dotnet binary, we should do the same for the paths inferred from environment variables. This makes users in mixed-mode scenarios less likely to experience errors.

HOW

🤖 Generated by Copilot at 8704a72