Open safesparrow opened 5 months ago
We should do two things here:
However, we should move to making that build message only generated logged in the first place if the verbosity is at a certain level, because that huge string in memory can't be doing well for our overall allocations.
We do have this msbuildLogger so we might even be able to remove the giant string completely and let that show errors/details.
Is your feature request related to a problem? Please describe. When MSBuild build fails, ProjInfo logs full MSBuild output which is very verbose. It happens here: https://github.com/ionide/proj-info/blob/22b59a7c9411512e7ca23fc376e98227546dd98e/src/Ionide.ProjInfo/Library.fs#L1062-L1065
Sample beginning of output:
Describe the solution you'd like Better control over how much output is produced in case of failure.
Describe alternatives you've considered Disable ProjInfo's logs through Serilog configuration - but that gets rid of useful log information.