await join() issue

[manishiitg]

Your environment.

• Version: master
• Browser: chrome/edge

What did you do?

This is how my code looks like the outline at least P.S using react

signalRef.current = new IonSFUJSONRPCSignal(host);
clientRef.current = new Client(signalRef.current, webrtcConfig);

await clientRef.current.join(meshidRef.current);

signalRef.current.onopen = async () => {
    ....
})

clientRef.current.ontrack = async (track, stream) => {
   ....
})

await publishStream()

Now the main bug comes here

await clientRef.current.join(meshidRef.current);

if i add an await here then if there is another peer on the call, i don't recieve his onTrack event. only if new peers join i recieve the onTrack not for people already on the call.

What did you expect?

i expect await should only wait for me to join on the call. if i use await it should mean i won't get ontrack of users already on the call

What happened?

[billylindeman]

await clientRef.current.join(meshidRef.current);

this should happen inside your signal.onopen callback

[manishiitg]

yes. i am already doing it inside the onopen callback. i wrote it outside by mistake

signalRef.current = new IonSFUJSONRPCSignal(host);
            clientRef.current = new Client(signalRef.current, webrtcConfig);

            signalRef.current.onopen = async () => {
                setNotification("signal opened...")
                clientRef.current.join(meshidRef.current);
                clearTimeout(joinTimeout.current)

this is the actual code as of now i have removed await from my code

[billylindeman]

Do you set the client.ontrack callback ahead of time? The behavior of await client.join did change recently (it now awaits for the api datachannel to arrive).

[manishiitg]

no my ontrack is after await join not before. i will check by putting it before it and see

[billylindeman]

@manishiitg did this solve your issue?

[manishiitg]

@billylindeman didn't check it yet. will do soon

[manishiitg]

for now just not using await.