codecov[bot]
commented
2 years ago Codecov Report
Base: 34.97% // Head: 35.68% // Increases project coverage by +0.70% :tada:
Coverage data is based on head (
733bb5e) compared to base (7b6cc7b). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #669 +/- ## ========================================== + Coverage 34.97% 35.68% +0.70% ========================================== Files 24 24 Lines 2633 2637 +4 ========================================== + Hits 921 941 +20 + Misses 1570 1554 -16 Partials 142 142 ``` | [Impacted Files](https://codecov.io/gh/pion/ion-sfu/pull/669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [pkg/sfu/mediaengine.go](https://codecov.io/gh/pion/ion-sfu/pull/669/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-cGtnL3NmdS9tZWRpYWVuZ2luZS5nbw==) | `85.18% <100.00%> (+1.18%)` | :arrow_up: | | [pkg/sfu/router.go](https://codecov.io/gh/pion/ion-sfu/pull/669/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-cGtnL3NmdS9yb3V0ZXIuZ28=) | `43.25% <0.00%> (+2.24%)` | :arrow_up: | | [pkg/sfu/subscriber.go](https://codecov.io/gh/pion/ion-sfu/pull/669/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-cGtnL3NmdS9zdWJzY3JpYmVyLmdv) | `56.41% <0.00%> (+7.69%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Description
ion-sfu redefines mime types already present in webrtc/pion. This leads to some issues as it appears the parsing of the SDP for codecs is not entirely case-insensitive.
Reference issue
Fix #661