search

ionorg / ion-sfu

Pure Go WebRTC SFU
MIT License
980 stars 238 forks source link

feat: add transceiver getter to downtrack #672

Open aalekseevx opened 1 year ago

aalekseevx commented 1 year ago

Transceiver getter adds more flexibility to downtrack API, e.g. track Mid can be retrieved from downtrack. Also, transceiver setter is already present.

aalekseevx commented 1 year ago

@grahamking, Hi! Thanks for the review, are there any blockers for merging?

grahamking commented 1 year ago

At least 1 approving review is required by reviewers with write access

The project moved from the pion org, which I am part of, to 'ionorg', which I am not, so I can't approve it. And the 'ionorg' member list is not public, so :man_shrugging: not sure what to do here. @ojroques maybe you can review?

grahamking commented 1 year ago

I also suspect the golangci-lint check is broken, has been broken for a while, so you may not be able to merge even with a review.

This project might be abandoned. Maybe ask in the Pion Slack?

ojroques commented 1 year ago

I'm not part of the organization either. I can't help sorry.