scheduler: memory assignment of templates is included in calculations

[pborn-ionos]

What steps did you take and what happened:

• Assigned a VM template (qm set $VMID --template 1) a high amount of memory, greater than the host's available resources
• Actually tried to provision a VM with 1024MB of memory
• Was presented with 0B available memory left error

What did you expect to happen:

• My requested VM to be provisioned, as VMs with the template flag can not start. Therefore their memory requests shouldn't be taken into consideration.

Anything else you would like to add:

Environment:

• Cluster-api-provider-proxmox version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[chengleqi]

E0120 05:46:40.571594       1 controller.go:324] "Reconciler error" err="failed to reconcile VM: cannot reserve 2147483648B of memory on node newpve: 0B available memory left" controller="proxmoxmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="ProxmoxMachine" ProxmoxMachine="default/proxmox-quickstart-control-plane-gnjd5" namespace="default" name="proxmox-quickstart-control-plane-gnjd5" reconcileID="2e95a13b-e769-4197-8a37-7287ee874c22"

Hi, My PVE Node has enough mem, but I got this error. Do you have any solution?

capmox-controller-manager' version is v0.1.1

[chengleqi]

I think I have found the reason. In the function below, the variable reservableMemory is set to 0 because the maximum memory set for my other virtual machines exceeds the node's memory. https://github.com/ionos-cloud/cluster-api-provider-proxmox/blob/ed0cbf14cf9ab78edbc21f9bc861d414e5552bc2/pkg/proxmox/goproxmox/api_client.go#L184

I have a question, why not directly use node.Memory.Free?

package main

import (
    "context"
    "crypto/tls"
    "fmt"
    "github.com/luthermonson/go-proxmox"
    "net/http"
)

func main() {
    insecureHTTPClient := http.Client{
        Transport: &http.Transport{
            TLSClientConfig: &tls.Config{
                InsecureSkipVerify: true,
            },
        },
    }
    tokenID := ""
    secret := ""

    client := proxmox.NewClient("https://192.168.3.50:8006/api2/json",
        proxmox.WithHTTPClient(&insecureHTTPClient),
        proxmox.WithAPIToken(tokenID, secret),
    )

    node, err := client.Node(context.Background(), "newpve")
    if err != nil {
        panic(err)
    }
    fmt.Println(node.Memory.Total / 1024 / 1024 / 1024)
    fmt.Println(node.Memory.Used / 1024 / 1024 / 1024)
    fmt.Println(node.Memory.Free / 1024 / 1024 / 1024)
}

Output:

node.Memory.Total: 62GB
node.Memory.Used: 15GB
node.Memory.Free: 46GB

[chengleqi]

Can you help me take a look at this problem? @mcbenjemaa