search

ionos-cloud / cluster-api-provider-proxmox

Cluster API Provider for Proxmox VE (CAPMOX)
Apache License 2.0
181 stars 24 forks source link

PROXMOX_TOKEN in CAPMOX is PROXMOX_SECRET in the Image-Builder which is error-prone #52

Closed 3deep5me closed 5 months ago

3deep5me commented 8 months ago

I created an image with image-builder, the environment variable for the "secret-key" is PROXMOX_TOKEN. In CAPMOX the same environment variable contains the "token-user".

During the clusterctl init the environment variable is preferred over the config-file, so i ended up to have an secret like this

apiVersion: v1
data:
  secret: M3OWRi
  token: M3OWRi
  url: aHqc29u

I would like to suggest to have the same naming as in the image-builder to save others the trouble shooting. PROXMOX_USERNAME & PROXMOX_TOKEN

I should be able to create a PR for that - if desired.

mcbenjemaa commented 8 months ago

Great Point.

The image builder vars are based on the packer plugin, So, if we want to support the same naming, we will need to rename those, and this will be a Breaking change.

you're welcome to add this.

65278 commented 6 months ago

We should at least get documentation in for this in CAPMOX v0.4.0.

wikkyk commented 5 months ago

See #173 and https://github.com/ionos-cloud/cluster-api-provider-proxmox/pull/54#issuecomment-1895747271 - we decided that remaining consistent with Proxmox VE is more important than being consistent with Packer.