regression in creation of mk8s nodepools - Githubissues

ionos-cloud / crossplane-provider-ionoscloud

The Crossplane Provider for IONOS Cloud gives the ability to manage IONOS Cloud infrastructure directly from Kubernetes.

Apache License 2.0

16 stars 6 forks source link

regression in creation of mk8s nodepools #255

Closed leroyshirto closed 3 months ago

leroyshirto commented 4 months ago

What happened?

There has been a reversion in functionallity. The fix implemented in PR https://github.com/ionos-cloud/crossplane-provider-ionoscloud/pull/243 appears to have been reverted by this recent PR: https://github.com/ionos-cloud/crossplane-provider-ionoscloud/pull/249/files#diff-58333b86186aa1a8ee33021762db2493a983b22ad698c96a8c1377a877eb81c6R323

The result of this is NodePool lan config which only rely on lanCondig e.g

lans:
- dhcp: true
  lanConfig:
    lanIdRef:
      name: my-lan

Will now result in an error as datacenterId will be set to empty string ""

cristiGuranIonos commented 3 months ago

fixed in v1.1.2