fix: error messages cutoff

[avirtopeanu-ionos]

What does this fix or implement?

Before

• Errors were cut off right where they got interesting

• Status codes were manually checked in the client package in an incomplete fashion, with lots of duplicated code

After

• Out of scope of PR: Moved the client code in internal pkg (according to https://github.com/golang-standards/project-layout)

• Out of scope of PR: fixed Client image funcs not returning pointers to Image(s)

• Added an extendable pkg "Response Sanitizer" which can take a map of HTTP Response Codes to Custom Messages (or use a default map) which throws an error if the status code is not 200-299. The package is importable in any other external repo. The custom message map can be easily modified or extended at runtime if you choose to add case-specific messages:

resp, err := c.DataCentersApi.DatacentersDelete(c.ctx, datacenterId).Execute()
if err = sdk-utils.SanitizeStatusCodeCustom(resp.StatusCode, resp.Message, api.CustomStatusCodeMessages.Set(405, "please delete the datacenter manually"), log.Info); err != nil {
    return err
}

• Added an SDK "Error Sanitizer" which (in this specific order) :
  • Converts error into OpenAPI Generic Error (it extends that type in the SDK)
  • Gets OpenAPI Error Body, which is a valid JSON
  • Queries the value at messages.message and return it
  • If it doesn't exist, compact the JSON and return the compacted JSON
  • If however the error conversion failed, at best we can strip newlines and spaces in the error, in hopes it is short enough.

Checklist

• [x] PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
• [x] Tests added or updated
• [ ] Documentation updated
• [x] Sonar Cloud Scan
• [ ] Changelog updated and version incremented (label: upcoming release)
• [ ] Github Issue linked if any
• [x] Jira task updated

[sonarcloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

54.6% Coverage
0.0% Duplication