ionos-cloud / ionoscloud-blockstorage-csi-driver

Container Storage Interface (CSI) plugin for IONOS Cloud block storage.
https://cloud.ionos.com
Apache License 2.0
1 stars 0 forks source link

fix: Remove fullname helm template helper #8

Closed avorima closed 3 months ago

avorima commented 3 months ago

What does this fix or implement?

I copied the install instructions from the chart README for a test and noticed this warning:

W0612 20:33:14.929907  209502 warnings.go:70] metadata.name: this is used in Pod names and hostnames, which can result in surprising behavior; a DNS label is recommended: [must be no more than 63 characters]

Since the chart name is already very long adding any other name can easily exceed the limit for pod names and this can easily be missed.

Having the name of all resources be the same as the helm chart should be fine, because you can only install one instance anyways.

Checklist