ionos-cloud / sdk-go

Apache License 2.0
7 stars 1 forks source link

Client should only retry on read only requests #6

Closed ionos-cloud-paas-bot closed 1 year ago

ionos-cloud-paas-bot commented 3 years ago

We observed issues when POST requests where duplicated in the cloud backend because the gateway responses timed out and the client immediately retried. Therefore consumers should handle server errors for writing requests.

https://github.com/ionos-cloud/sdk-go/blob/7b747fa98d630dc778392f7727676c02e8bcc154/client.go#L273

Ntr0 commented 3 years ago

That was me, using the bot account m(

avorima commented 1 year ago

POST request are no longer duplicated on server errors

avorima commented 1 year ago

Sorry, I was looking at the master branch of the sdk-resources. It's not yet released

avorima commented 1 year ago

Ok, now it's fixed