ionos-cloud / sdk-nodejs

Apache License 2.0
1 stars 0 forks source link

Update READMEs and delete deprecated docs #7

Closed adeatcu-ionos closed 2 years ago

adeatcu-ionos commented 2 years ago

Solves https://github.com/ionos-cloud/sdk-nodejs/issues/5 by fixing the example from the README.md.

This also represents a follow up for this discussion.

In this PR, the READMEs are updated accordingly and the deprecated documentation is deleted.

DanielRuf commented 2 years ago

Hi, there is also one more at https://github.com/ionos-cloud/sdk-nodejs/tree/master/docs#usage

DanielRuf commented 2 years ago

Besides that, there is a very old DOCS.md file at https://github.com/ionos-cloud/sdk-nodejs/blob/master/DOCS.md which contains more suche cases.

Not sure if this file is still used or obsolete like the old lowercase files (see https://github.com/ionos-cloud/sdk-nodejs/issues/5#issuecomment-1259487707).

adeatcu-ionos commented 2 years ago

@DanielRuf

Hi, there is also one more at https://github.com/ionos-cloud/sdk-nodejs/tree/master/docs#usage

Hi, I fixed this typo in this commit.

Besides that, there is a very old DOCS.md file at https://github.com/ionos-cloud/sdk-nodejs/blob/master/DOCS.md which contains more suche cases.

I discussed with the team and we decided to delete those files. I deleted them in this commit.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

adeatcu-ionos commented 2 years ago

@mimihalescu please review again because I added another example in the READMEs as a follow up to this comment, thank you!

DanielRuf commented 2 years ago

Perfect, thank you very much =)